cmd: fix config file from env variable issue in subcommands #4344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes dgraph-io#4311 * Each subcommand can specify the config file to use using the environment varaible which is of the form `<ENV_PREFIX>_CONFIG`, for example `DGRAPH_ZERO_CONFIG`. So with a `config.json` looking like this we can override the config variables. ```json { "my": "localhost:5180", "port_offset": 100, "idx": 1 } ``` Override the configuration using the above config file using the command ```bash DGRAPH_ALPHA_CONFIG=config.json dgraph alpha DGRAPH_ZERO_CONFIG=config.json dgraph zero ``` Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
prashant-shahi
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
Signed-off-by: fristonio <deepshpathak@gmail.com>
prashant-shahi
approved these changes
Dec 4, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
environment varaible which is of the form
<ENV_PREFIX>_CONFIG, forexample
DGRAPH_ZERO_CONFIG.So with a
config.jsonlooking like this we can override the configvariables.
{ "my": "localhost:5180", "port_offset": 100, "idx": 1 }Override the configuration using the above config file using the command
Signed-off-by: Deepesh Pathak deepshpathak@gmail.com
This change is